From: Steven Baltakatei Sandoval <baltakatei@gmail.com>
Date: Sun, 28 Jun 2020 22:52:27 +0000 (+0000)
Subject: fix(bktemplate):Use "$*" instead of "$@" in error messages
X-Git-Tag: 0.2.0~30
X-Git-Url: https://zdv2.bktei.com/gitweb/BK-2020-03.git/commitdiff_plain/60fdb80b59ff5d5f384ed8bd92f1203feafd1dd7?ds=sidebyside

fix(bktemplate):Use "$*" instead of "$@" in error messages

Reference: Argument mixes string and array. Use * or separate
argument. https://github.com/koalaman/shellcheck/wiki/SC2145
---

diff --git a/unitproc/bktemplate b/unitproc/bktemplate
index 1ffe237..82caf02 100755
--- a/unitproc/bktemplate
+++ b/unitproc/bktemplate
@@ -181,7 +181,7 @@ processArguments() {
     # Perform work
     while [ ! $# -eq 0 ]; do   # While number of arguments ($#) is not (!) equal to (-eq) zero (0).
 	#1>&2 echo "DEBUG:Starting processArguments while loop." # Debug stderr message. See [1].
-        #1>&2 echo "DEBUG:Provided arguments are:""$@" # Debug stderr message. See [1].
+        #1>&2 echo "DEBUG:Provided arguments are:""$*" # Debug stderr message. See [1].
 	case "$1" in
 	    -h | --help) showUsage; exit 1;; # Display usage.
 	    --version) showVersion; exit 1;; # Show version
@@ -270,7 +270,7 @@ checkExecutables() {
     vbm "DEBUG:checkExecutables function called."
     declare -a candidateCommandsNames # Initialize array for storing positional arguments provided to this function.
     candidateCommandsNames=("$@") # Save positional arguments to variable as string. See [3].
-    vbm "DEBUG:candidateCommandsNames:""$@"
+    vbm "DEBUG:candidateCommandsNames:""$*"
     vbm "DEBUG:candidateCommandsNames[0]:""${candidateCommandsNames[0]}"
     vbm "DEBUG:candidateCommandsNames[1]:""${candidateCommandsNames[1]}"
     vbm "DEBUG:candidateCommandsNames[2]:""${candidateCommandsNames[2]}"
@@ -349,7 +349,7 @@ checkapp() {
     # Output: adds/updates key(value) to global assoc array 'appRollCall'
     local returnState    
     #echo "DEBUG:$(date +%S.%N)..Starting checkapp function."
-    #echo "DEBUG:args: $@"
+    #echo "DEBUG:args: $*"
     #echo "DEBUG:returnState:$returnState"
 
     #===Process Args===