From: Steven Baltakatei Sandoval <baltakatei@gmail.com>
Date: Thu, 25 Jul 2024 18:38:59 +0000 (+0000)
Subject: fix(user/bkots):Fix shellcheck delinter complaints
X-Git-Url: https://zdv2.bktei.com/gitweb/BK-2020-03.git/commitdiff_plain/3329584b8848c977d0d05bf6757cf4ecb812efe3?ds=inline;hp=21beb7be61fdf90ea0df0a542c5f29f70a4a2434

fix(user/bkots):Fix shellcheck delinter complaints
---

diff --git a/user/bkots b/user/bkots
index ec371f6..3c9705c 100755
--- a/user/bkots
+++ b/user/bkots
@@ -200,7 +200,7 @@ showVersion() {
     vbm "DEBUG:showVersion function called."
 
     cat <<'EOF'
-bkots 2.1.0
+bkots 2.1.1
 Copyright (C) 2022 Steven Baltakatei Sandoval
 License GPLv3: GNU GPL version 3
 This is free software; you are free to change and redistribute it.
@@ -674,7 +674,7 @@ main() {
             path_prf="$(cut -d $'\n' -f1 < <(echo "$item"))";
             if [[ -z "$path_prf" ]]; then
                 yell "ERROR:blank upgrade item encountered. Skipping:item:$item";
-                continue;
+                return 1; # would have been `continue` were it not in a subshell
             fi;
             vbm "DEBUG:Attempting to upgrade proof file:path_prf:$path_prf";
             if [[ ! $option_dry_run == "true" ]]; then
@@ -684,7 +684,7 @@ main() {
 
                     #### assemble command
                     local -a cmd_temp;
-                    cmd_temp+=("ots");
+                    cmd_temp=("ots");
                     if [[ "$opVerbose" = "true" ]]; then cmd_temp+=("-v"); fi;
                     cmd_temp+=("-l" "$url" "--no-default-whitelist");
                     cmd_temp+=("upgrade" "$path_prf");
@@ -709,7 +709,7 @@ main() {
             path_prf="$(cut -d $'\n' -f2 < <(echo "$item"))";
             if [[ -z "$path_src" ]] || [[ -z "$path_prf" ]]; then
                 yell "ERROR:blank verify item encountered. Skipping:item:$item";
-                continue;
+                return 1; # would have been `continue` were it not in a subshell
             fi;
             vbm "DEBUG:Attempting to verify source file:path_src:$path_src";
             vbm "DEBUG:    against proof file:          path_prf:$path_prf";
@@ -720,7 +720,7 @@ main() {
 
                     #### assemble command
                     local -a cmd_temp;
-                    cmd_temp+=("ots");
+                    cmd_temp=("ots");
                     if [[ "$opVerbose" = "true" ]]; then cmd_temp+=("-v"); fi;
                     cmd_temp+=("-l" "$url" "--no-default-whitelist");
                     cmd_temp+=("verify" "-f" "$path_src" "$path_prf");
@@ -744,14 +744,14 @@ main() {
             path_src="$(cut -d $'\n' -f1 < <(echo "$item"))";
             if [[ -z "$path_src" ]]; then
                 yell "ERROR:blank stamp item encountered. Skipping:item:$item";
-                continue;
+                return 1; # would have been `continue` were it not in a subshell
             fi;
             vbm "DEBUG:Attempting to stamp source file:path_src:$path_src";
             if [[ ! $option_dry_run == "true" ]]; then
 
                 #### assemble command
                 local -a cmd_temp;
-                cmd_temp+=("ots");
+                cmd_temp=("ots");
                 if [[ "$opVerbose" = "true" ]]; then cmd_temp+=("-v"); fi;
                 cmd_temp+=("stamp" "$path_src");
                 if [[ "$opVerbose" = "true" ]]; then declare -p cmd_temp; fi;